Add omega support for single column tests#435
Add omega support for single column tests#435cbegeman wants to merge 47 commits intoE3SM-Project:mainfrom
Conversation
|
@hyungyukang This is a starting point when you're ready test vertical mixing tendencies with E3SM-Project/Omega#310. There may be additional work to support Omega. |
|
@cbegeman , I’ve tested this PR with Omega after implementing the implicit vertical mixing, using @katsmith133 's vertical mixing module PR (E3SM-Project/Omega#310). There are a few things that currently need to be adjusted manually when running Omega, and I also encountered an issue with visualization. I believe both of these can be fixed in a straightforward way. Despite these issues, I was able to run the test successfully and compare the results with those from MPAS-Ocean. In this directory, some changes to omega.ymlIn the After the test, I was able to see I will post the results in another comment. |
| config_use_activeTracers_surface_restoring: true | ||
| config_use_activeTracers_interior_restoring: true | ||
| cvmix: | ||
| config_cvmix_shear_mixing_scheme: KPP |
There was a problem hiding this comment.
| config_cvmix_shear_mixing_scheme: KPP | |
| config_cvmix_shear_mixing_scheme: PP |
| config_use_activeTracers_interior_restoring: true | ||
| cvmix: | ||
| config_cvmix_shear_mixing_scheme: KPP | ||
| config_use_cvmix_kpp: true |
There was a problem hiding this comment.
| config_use_cvmix_kpp: true | |
| config_use_cvmix_kpp: false |
| config_cvmix_kpp_matching: MatchBoth | ||
| config_cvmix_kpp_interpolationOMLType: cubic |
There was a problem hiding this comment.
| config_cvmix_kpp_matching: MatchBoth | |
| config_cvmix_kpp_interpolationOMLType: cubic |
For convection, my understanding is that Omega does not yet support evaporative forcing. @katsmith133 and I talked about starting off with unstable stratification but I don't have this included yet in this branch. I'll put that on my to-do list. For shear, I think we either need to @katsmith133 let me know if you have recommendations for these values. Otherwise I can play around with them a bit. |
|
@hyungyukang In your Let's also leave |
|
@cbegeman , Thanks for the suggestions! After the VMix module was merged into the develop branch, I reworked the tendency-term implementation on a new branch ( I tested again ( For MPAS-Ocean, I also reran the tests using your suggested settings: It appears that there is no noticeable change compared to the initial state.
If you have any suggestions you want to test, please let me know. |
9d93b97 to
9fc5f46
Compare
|
@vanroekel @katsmith133 I realized that I didn't set Here's the namelist file for the wind-driven shear column test case with no vertical advection: |
|
One more change -> config_use_cvmix_kpp = .false. Also thinking about this I'm fairly certain each column in this case should be BFB with each other for a constant stress + heat + evap flux. I can't think why we would generate vertical velocity in this case. |
cefaeaf to
df452e5
Compare
TestingBoth MPAS-Ocean and Omega have been run on chrys with intel, openmpi and the MPAS-Ocean issues:
Omega issues:
Polaris issues:
|
df452e5 to
28f622f
Compare
…ual single column tests, not the group
28f622f to
e853f41
Compare
| VelDiffTendencyEnable: false | ||
| VelHyperDiffTendencyEnable: false | ||
| VelVertMixTendencyEnable: true | ||
| PresForceTendencyEnable: false |
There was a problem hiding this comment.
| PresForceTendencyEnable: false |
This term does not exist anymore after rewriting PGF in Omega.
| VelVertMixTendencyEnable: true | ||
| PresForceTendencyEnable: false | ||
| PresGradForceTendencyEnable: false | ||
| GeoptGradTendencyEnable: false |
There was a problem hiding this comment.
| GeoptGradTendencyEnable: false |
This term is included in the PGF.
| VelHyperDiffTendencyEnable: false | ||
| VelVertMixTendencyEnable: true | ||
| PresForceTendencyEnable: false | ||
| PresGradForceTendencyEnable: false |
There was a problem hiding this comment.
| PresGradForceTendencyEnable: false | |
| PressureGradTendencyEnable: false |
| config_cvmix_num_ri_smooth_loops: 0 | ||
| streams: |
There was a problem hiding this comment.
| config_cvmix_num_ri_smooth_loops: 0 | |
| streams: | |
| config_cvmix_num_ri_smooth_loops: 0 | |
| debug: | |
| config_disable_thick_sflux: true | |
| config_disable_vel_hadv: true | |
| config_disable_vel_coriolis: true | |
| config_disable_vel_pgrad: true | |
| config_disable_tr_sflux: true | |
| streams: |
Turn off some tendencies in MPAS-O to match the tendency settings used in Omega.
| config_cvmix_background_diffusion: 0. | ||
| config_cvmix_background_viscosity: 0. |
There was a problem hiding this comment.
Are these supposed to be 0? If not, they should probably be set as shown below:
| config_cvmix_background_diffusion: 0. | |
| config_cvmix_background_viscosity: 0. | |
| config_cvmix_background_diffusion: 1.0e-5 | |
| config_cvmix_background_viscosity: 1.0e-4 |
|
I retested To match the MPAS-Ocean equations, I cherry-picked E3SM-Project/Omega#370 to enable the constant EOS option. Using the
Note that the I will run the Ekman test later. |






Add omega support for single column tests and reorganize for shared init steps
Checklist
* [ ] Developer's Guide has been updatedapi.md) has any new or modified class, method and/or functions listedTestingcomment in the PR documents testing used to verify the changes